From: Markus Armbruster <[email protected]> It shouldn't fail, and no caller checks for failure. Make failure fatal.
Maintainers of affected machines cc'ed. Cc: Anthony Liguori <[email protected]> Cc: "Michael S. Tsirkin" <[email protected]> Cc: Aurelien Jarno <[email protected]> Cc: Leon Alrae <[email protected]> Cc: Blue Swirl <[email protected]> Signed-off-by: Markus Armbruster <[email protected]> Signed-off-by: Andreas Färber <[email protected]> --- hw/char/parallel.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/hw/char/parallel.c b/hw/char/parallel.c index 710cefc..4079554 100644 --- a/hw/char/parallel.c +++ b/hw/char/parallel.c @@ -642,22 +642,16 @@ static void parallel_register_types(void) type_init(parallel_register_types) -static bool parallel_init(ISABus *bus, int index, CharDriverState *chr) +static void parallel_init(ISABus *bus, int index, CharDriverState *chr) { DeviceState *dev; ISADevice *isadev; - isadev = isa_try_create(bus, "isa-parallel"); - if (!isadev) { - return false; - } + isadev = isa_create(bus, "isa-parallel"); dev = DEVICE(isadev); qdev_prop_set_uint32(dev, "index", index); qdev_prop_set_chr(dev, "chardev", chr); - if (qdev_init(dev) < 0) { - return false; - } - return true; + qdev_init_nofail(dev); } void parallel_hds_isa_init(ISABus *bus, int n) -- 2.1.4
