On 2015-02-11 at 22:07, Wen Congyang wrote:
Signed-off-by: Wen Congyang <[email protected]> Signed-off-by: zhanghailiang <[email protected]> Signed-off-by: Gonglei <[email protected]> --- block/Makefile.objs | 1 + block/blkcolo-buffer.c | 324 +++++++++++++++++++++++++++++++++++++++++++++++++ block/blkcolo.h | 35 ++++++ 3 files changed, 360 insertions(+) create mode 100644 block/blkcolo-buffer.c create mode 100644 block/blkcolo.h
In general: Can you please add some prefix to the non-static functions, like colo_*?
As for the design questions regarding this block driver, I should probably leave that to Fam and John (because they seemed to have an idea how to approach the issue at hand using a different implementation, based on functionality that's already (or close to become) part of qemu).
Therefore, I'm hesitating to review this patch (and the following ones) until you've reached a conclusion on how to proceed.
Max
