On 19 January 2015 at 12:55, Gerd Hoffmann <[email protected]> wrote:
> Hi,
>
> This patch series allows display device emulations to negotiate with
> the UI code which pixman formats it can handle for shared surfaces.
>
> Based on patches from Benjamin Herrenschmidt, sent to the list for
> review ten days ago, here we go with the pull request.
>
> please pull,
> Gerd
>
> The following changes since commit 1e42c353469cb58ca4f3b450eea4211af7d0b147:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20150116' into staging (2015-01-16
> 12:06:41 +0000)
>
> are available in the git repository at:
>
>
> git://git.kraxel.org/qemu tags/pull-console-20150119-1
>
> for you to fetch changes up to 877417d9ae6846bea4744b198131a5fe5117d7a5:
>
> ui/sdl2: Support shared surface for more pixman formats (2015-01-19
> 13:33:26 +0100)
Applied, thanks.
You forgot to add your maintainer's signoff to one of Ben's patches.
Since it was a one-liner I didn't think it was worth bouncing the
pullreq for, but you might want to consider adding something to your
pre-pull sanity checks. I use:
if ! git rev-list HEAD | grep -q $(git rev-parse master) ; then
echo "master is not a parent commit of $BRANCH -- rebase!"
exit 1
fi
# Check all commits have our signoff
bad=no
for rev in $(git rev-list master..HEAD); do
if git log ${rev}^! | grep -q "Signed-off-by: $SIGNOFF"; then
continue
fi
echo "Error: commit ${rev} missing signoff"
bad=yes
done
if [ "$bad" = "yes" ]; then
exit 1
fi
thanks
-- PMM
