On Wed, 26 Nov 2014 13:11:24 +0300 "Denis V. Lunev" <[email protected]> wrote:
> From: Raushaniya Maksudova <[email protected]> > > The idea is that all other virtio devices are calling this helper > to merge properties of the proxy device. This is the only difference > in between this helper and code in inside virtio_instance_init_common. > The patch should not cause any harm as property list in generic balloon > code is empty. > > This also allows to avoid some dummy errors like fixed by this > commit 91ba21208839643603e7f7fa5864723c3f371ebe > Author: Gonglei <[email protected]> > Date: Tue Sep 30 14:10:35 2014 +0800 > virtio-balloon: fix virtio-balloon child refcount in transports > > Signed-off-by: Denis V. Lunev <[email protected]> > Acked-by: Raushaniya Maksudova <[email protected]> > CC: Cornelia Huck <[email protected]> > CC: Christian Borntraeger <[email protected]> > CC: Anthony Liguori <[email protected]> > CC: Michael S. Tsirkin <[email protected]> > --- > hw/s390x/virtio-ccw.c | 5 ++--- > hw/virtio/virtio-pci.c | 5 ++--- > 2 files changed, 4 insertions(+), 6 deletions(-) Shouldn't this have the sign-off of the author (rather than the ack) as well? Otherwise, looks sane.
