On 11/20/2014 11:21 AM, Don Slutz wrote: > c/s 9b23cfb76b3a5e9eb5cc899eaf2f46bc46d33ba4 > > or > > c/s b154537ad07598377ebf98252fb7d2aff127983b > > moved the testing of xen_enabled() from pc_init1() to > pc_machine_initfn(). > > xen_enabled() does not return the correct value in > pc_machine_initfn(). > > Changed vmport from a bool to an enum. Added the value "auto" to do > the old way. > > Signed-off-by: Don Slutz <[email protected]> > --- > > v4: > Michael S. Tsirkin, Eric Blake, Eduardo Habkost: > Rename vmport to OnOffAuto and move to qapi/common.json > Eduardo Habkost: > Simpler convert of enum to no_vmport. > Michael S. Tsirkin: > Add assert for ON_OFF_AUTO_MAX. > > hw/i386/pc.c | 23 ++++++++++++++--------- > hw/i386/pc_piix.c | 10 +++++++++- > hw/i386/pc_q35.c | 10 +++++++++- > include/hw/i386/pc.h | 2 +- > qapi/common.json | 15 +++++++++++++++ > qemu-options.hx | 8 +++++--- > vl.c | 2 +- > 7 files changed, 54 insertions(+), 16 deletions(-)
I've only reviewed the qapi/common.json and qemu-options.hx files for QMP interface (and will leave the rest of the patch to others), but I'm okay with the changes to those files. I guess that means no R-b, since I didn't do a full review, so here's a weaker: Acked-by: Eric Blake <[email protected]> if you think it is worth adding. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
