On 19 November 2014 13:19, Eric Blake <[email protected]> wrote: > Use of -a and -o in [[]] is a bit better, but I still HIGHLY recommend > that constructs like this be rewritten as [ -n "$p" ] && [ -x "$p" ] for > avoidance of confusion and prevention of copy-pasting the test to > non-bash shells. But that would be a separate patch.
Yeah, this is one of those issues I tend to pick up in patches which change our shell scripts, but we still have a fair amount of existing code that isn't up to that standard. -- PMM
