On 6 November 2014 15:51, Greg Bellows <[email protected]> wrote:
> From: Fabian Aggeler <[email protected]>
>
> Adds secure and non-secure bank register suport for TTBCR.
> Added new struct to compartmentalize the TCR data and masks. Removed old
> tcr/ttbcr data and added a 4 element array of the new structs in cp15. This
> allows for one entry per EL. Added a CP register definition for TCR_EL3.
>
> Signed-off-by: Fabian Aggeler <[email protected]>
> Signed-off-by: Greg Bellows <[email protected]>
> +static void *raw_ptr(CPUARMState *env, const ARMCPRegInfo *ri)
> +{
> + return (char *)(env) + (ri)->fieldoffset;
> +}
You don't need the brackets round "ri" here, since this isn't
a macro.
> + /* Get the TCR bank based on our security state*/
Missing space before "*/".
Otherwise
Reviewed-by: Peter Maydell <[email protected]>
thanks
-- PMM
