Am 09.10.2014 um 15:47 schrieb Luiz Capitulino: > On Wed, 01 Oct 2014 10:54:44 +0200 > Markus Armbruster <arm...@redhat.com> wrote: > >> Ping? >> >> Markus Armbruster <arm...@redhat.com> writes: >> >>> This command lists PCMCIA sockets and cards. Only a few ARM boards >>> have sockets (akita, borzoi, connex, mainstone, spitz, terrier, tosa, >>> verdex, z2), the only card is the DSCM-1xxxx Hitachi Microdrive (qdev >>> "microdrive"), and it is only inserted during machine init, if ever. >>> So this command doesn't really tell anybody anything new so far. >>> >>> Moreover, pcmcia_socket_unregister() has a use-after-free bug, flagged >>> by Coverity. Has never been used, because there has never been code >>> to eject a PCMCIA card. >>> >>> Not worth fixing & converting to QMP. Remove it. > > Sorry for the long delay on this one. But this patch is more about PCMCIA > support in QEMU than HMP, so I can provide my ACK, but I don't think this > is HMP material. > > Acked-by: Luiz Capitulino <lcapitul...@redhat.com>
As the probably last one to have touched the ugly PCMCIA code, Acked-by: Andreas Färber <afaer...@suse.de> Maybe take it through the arm queue due to affected machines, Peter? Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
