On 08/25/2014 05:19 AM, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova <[email protected]> > --- > qapi-schema.json | 3 ++ > qapi/trace.json | 65 ++++++++++++++++++++++++++++++++++++++++++++ > qmp-commands.hx | 35 ++++++++++++++++++++++++ > trace/Makefile.objs | 1 + > trace/qmp.c | 75 > +++++++++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 179 insertions(+) > create mode 100644 qapi/trace.json > create mode 100644 trace/qmp.c
> +##
> +# @trace-event-set-state:
> +#
> +# Set the dynamic tracing state of events.
> +#
> +# @name: Event name pattern (case-sensitive glob).
> +# @enable: Whether to enable tracing.
> +# @ignore-unavailable: #optional Do not match unavailable events with @name.
Would be nice to state that this bool defaults to false (at least,
that's my assumption).
> +
> +Query the state of events.
> +
> +Example:
> +
> +-> { "execute": "trace-event-get-state", "arguments": { "name":
> "qemu_memalign" } }
> +<- { "return": [ { "name": "qemu_memalign", "state": "disabled" } ] }
It would be nice to use a glob in the "name" of the example, and show a
multi-element array as the result.
Those changes can be done in a followup patch, since Stefan has already
queued this patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
