On 08/22/2014 12:16 PM, Lluís Vilanova wrote: >>> +# @name: Event name. >>> +# @sstatic: Static tracing state. >>> +# @sdynamic: Dynamic tracing state. > >> Does the leading 's' add any value? QAPI doesn't have to use obscure >> abbreviations. > > It felt wrong to have a JSON attribute named differently from the C struct > (static is a reserved word).
The qapi generator will automatically convert 'static' in QMP to q_static in C code. I'd rather the QMP looks clean, even if the underlying C code has to deal with a munged name. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
