Il 21/08/2014 11:22, Peter Maydell ha scritto: > On 21 August 2014 08:35, Johny Mattsson <[email protected]> wrote: >> > When using snapshots on e.g. the VersatilePB board, the pflash driver >> > would report an error and get reset at times after resuming the snapshot. >> > This was traced down to the 'romd' flag in the pflash emulation which was >> > not being persisted in the snapshot. >> > >> > Author: Bernd Meyer <[email protected]> >> > Signed-off-by: Johny Mattsson <[email protected]> > Paolo -- remind me, is it the device model's job to keep track of > what its memory regions are doing, rather than the memory region's > job to make sure it's migrated? I definitely remember having this > argument with Avi before but I can't remember the outcome... >
It's the device model's job. I agree with your review, and I think romd=1 is the right default value if the subsection is not present. Paolo
