From: Stefan Weil <[email protected]> Static code analyzers complain about a dubious & operation used for a boolean value. The code does not test the PSTATE_SP bit as it should.
Cc: Peter Maydell <[email protected]> Signed-off-by: Stefan Weil <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]> --- target-arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index a7f82f3..d709285 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -1853,7 +1853,7 @@ static uint64_t aa64_dczid_read(CPUARMState *env, const ARMCPRegInfo *ri) static CPAccessResult sp_el0_access(CPUARMState *env, const ARMCPRegInfo *ri) { - if (!env->pstate & PSTATE_SP) { + if (!(env->pstate & PSTATE_SP)) { /* Access to SP_EL0 is undefined if it's being used as * the stack pointer. */ -- 1.9.3
