> -----Original Message----- > From: Stefan Hajnoczi [mailto:[email protected]] > Sent: Monday, July 28, 2014 5:49 PM > To: Gonglei (Arei) > Cc: [email protected]; [email protected]; > [email protected] > Subject: Re: [Qemu-devel] Possible null-ptr dereference > > On Mon, Jul 28, 2014 at 06:03:45AM +0000, Gonglei (Arei) wrote: > > Hi, > > > > Should be easy to fix though. Does the following help? > > > > (Cc'ing Stefan & Kevin) > > > > --> > > xen_disk: fix possible null-ptr dereference > > > > Signed-off-by: Gonglei <[email protected]> > > --- > > hw/block/xen_disk.c | 1 + > > 1 file changed, 1 insertion(+) > > This code path can never be reached since protocol is always set to one > of 3 valid values in xen_disk.c. Therefore, I'm not merging this for > QEMU 2.1 where we are only taking critical bug fixes now. > OK.
> Still, it will help silence static checkers and make the intent clear to > readers. > > Thanks, applied to my block-next tree for QEMU 2.2: > https://github.com/stefanha/qemu/commits/block-next > Thanks. Best regards, -Gonglei
