On 2 July 2014 11:46, Kirill Batuzov <batuz...@ispras.ru> wrote: > On Tue, 1 Jul 2014, Pavel Dovgaluk wrote: >> +replay/replay.o replay/replay-events.o replay/replay-internal.o: CFLAGS+= >> -Wno-unused-result
> Is this change really needed? I think it is better to avoid disabling > compiler warnings without a good reason clearly stated in the commit > message. In this case these are new files and they're not some other project's files we're importing, so we should just make them comply with QEMU's usual warning levels from the start. thanks -- PMM