On Mon, Jun 09, 2014 at 11:42:14AM +0100, Peter Maydell wrote: > On 9 June 2014 11:25, Hu Tao <[email protected]> wrote: > > Signed-off-by: Hu Tao <[email protected]> > > --- > > include/qemu/range.h | 124 > > +++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 124 insertions(+) > > > > diff --git a/include/qemu/range.h b/include/qemu/range.h > > index aae9720..8879f8a 100644 > > --- a/include/qemu/range.h > > +++ b/include/qemu/range.h > > @@ -3,6 +3,7 @@ > > > > #include <inttypes.h> > > #include <qemu/typedefs.h> > > +#include "qemu/queue.h" > > > > /* > > * Operations on 64 bit address ranges. > > @@ -60,4 +61,127 @@ static inline int ranges_overlap(uint64_t first1, > > uint64_t len1, > > return !(last2 < first1 || last1 < first2); > > } > > > > +typedef struct SignedRangeList SignedRangeList; > > + > > +typedef struct SignedRange { > > + int64_t start; > > + int64_t length; > > + > > + QTAILQ_ENTRY(SignedRange) entry; > > +} SignedRange; > > + > > +QTAILQ_HEAD(SignedRangeList, SignedRange); > > This seems to be missing documentation about what the > semantics are and why we need it as well as the standard > Range. For instance, what does a SignedRange with a > negative length mean? > > thanks > -- PMM
Yes I also don't care for list macros being mixed in with structure. Also, numa surely uses positive numbers? why do you want signed values? -- MST
