On 06/03/2014 03:21 PM, Michael Roth wrote: > Quoting Tomoki Sekiyama (2014-05-22 08:56:53) >> When an array of mount point paths is specified as 'mountpoints' argument >> of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the file >> systems mounted on specified paths in Linux. >> This would be useful when the host wants to create partial disk snapshots. > > Since this isn't really applicable for win32, and it's hard to discover > optional params via guest-info without some extensive changes to how we handle > capabilities negotiation, I think it makes more sense to introduce a new > command for this, something like guest-fsfreeze-freeze-filesystems, which we > can easily discover and properly mark as unsupported on win32.
Bikeshedding on the proposed name: given that 'fs' is an abbreviation of 'filesystem', "fsfreeze-freeze-filesystems" sounds rather redundant. I would suggest guest-fsfreeze-list as a shorter name that conveys the intent, without quite as much repetition. > > Other than that looks good. > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
