Am 28.05.2014 um 09:31 hat Markus Armbruster geschrieben: > Fam Zheng <[email protected]> writes: > > > In vmdk_create and vmdk_create_extent, initialize local_err before using > > it, and don't leak it on error. > > > > Reported-by: Markus Armbruster <[email protected]> > > Signed-off-by: Fam Zheng <[email protected]> > > --- > > block/vmdk.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-)
> local_err and error_propagate() are actually superfluous, but I'll fix > that on top, along with many other instances. What should really be fixed is that bdrv_open/create_file() return an -errno int in addition to using Error. > Reviewed-by: Markus Armbruster <[email protected]> Thanks, applied to the block branch. Kevin
