On 27 May 2014 12:24, Christoffer Dall <[email protected]> wrote: > This fix a bug introduced by commit > 50a2c6e55fa2ce5a2916a2c206bad2c6b0e06df1, but I'm not sure it is a > proper fix.
This commit message could use being beefed up a bit. (I tend to recommend that commentary like "not sure this is right" goes below the '---'.) Suggested: target-arm: Fix segfault on startup when KVM enabled Commit 50a2c6e55fa introduced a bug where QEMU would segfault on startup when using KVM on ARM hosts, because kvm_arm_reset_cpu() accesses cpu->cpreg_reset_values, which is not allocated before kvm_arch_init_vcpu(). Fix this by not calling cpu_reset() until after qemu_init_vcpu(). > Acked-by: Paolo Bonzini <[email protected]> > Signed-off-by: Christoffer Dall <[email protected]> Reviewed-by: Peter Maydell <[email protected]> thanks -- PMM
