23.05.2014 15:24, Markus Armbruster пишет:
> It's not locally obvious, and Coverity can't see it either.
>
> Signed-off-by: Markus Armbruster <[email protected]>
> Reviewed-by: Alon Levy <[email protected]>
> ---
> libcacard/vcard_emul_nss.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
> index 2048917..4f55e44 100644
> --- a/libcacard/vcard_emul_nss.c
> +++ b/libcacard/vcard_emul_nss.c
> @@ -1181,6 +1181,7 @@ vcard_emul_options(const char *args)
> vreaderOpt = g_renew(VirtualReaderOptions, opts->vreader,
> reader_count);
> }
> + assert(vreaderOpt);
> opts->vreader = vreaderOpt;
> vreaderOpt = &vreaderOpt[opts->vreader_count];
> vreaderOpt->name = g_strndup(name, name_length);
Shouldn't the assignment be moved up one line into the if {}
statement instead?
Sigh, thats a second comment about this code... :)
Thanks,
/mjt
