On 19 May 2014 10:23, Edgar E. Iglesias <[email protected]> wrote:
> From: "Edgar E. Iglesias" <[email protected]>
>
> Signed-off-by: Edgar E. Iglesias <[email protected]>
> @@ -2356,6 +2370,12 @@ void register_cp_regs_for_features(ARMCPU *cpu)
> }
> if (arm_feature(env, ARM_FEATURE_EL2)) {
> define_arm_cp_regs(cpu, v8_el2_cp_reginfo);
> + } else {
> + /* If EL2 is missing but higher ELs are enabled, we need to
> + * register the no_el2 reginfos. */
Very nitpicky, but my preferred multiline comment style puts the
final "*/" on its own line rather than at the end of the preceding.
> + if (arm_feature(env, ARM_FEATURE_EL3)) {
> + define_arm_cp_regs(cpu, v8_no_el2_cp_reginfo);
> + }
> }
> if (arm_feature(env, ARM_FEATURE_EL3)) {
> define_arm_cp_regs(cpu, v8_el3_cp_reginfo);
> --
> 1.8.3.2
thanks
-- PMM
