On 05/13/2014 02:34 AM, Alex Bennée wrote: > I'm having trouble figuring out what the sizemask stuff was trying to > achieve and if it's required/covered after the change. Is the final > helper now the one defined as? > > DEF(div_i32, 1, 2, 0, IMPL(TCG_TARGET_HAS_div_i32)) > > it's hard to follow the parameters of this compared to the target > helpers where the the argument sizes are a lot more explicit.
The sizemask stuff is about encoding the argument types of the function. What you've quoted above is not the helper, but the TCG opcode. The helper is defined as DEF_HELPER_FLAGS_2(div_i32, TCG_CALL_NO_RWG_SE, s32, s32, s32) in the previous patch. r~
