On Mon, 12 May 2014 10:01:31 +0200 Christian Borntraeger <[email protected]> wrote:
> On 08/05/14 15:03, Cornelia Huck wrote: > > Introduce a common parent class for both cases, where kvm and non-kvm > > can hook up callbacks. This will be used by follow-on patches for > > adapter registration and mapping. > > > > We now always have a flic, regardless of whether we use kvm; the > > non-kvm implementation just doesn't do anything. > > > > Reviewed-by: Jens Freimann <[email protected]> > > Signed-off-by: Cornelia Huck <[email protected]> > > --- > > default-configs/s390x-softmmu.mak | 3 +- > > hw/intc/Makefile.objs | 1 + > > hw/intc/s390_flic.c | 318 > > ++++-------------------------------- > > hw/intc/s390_flic_kvm.c | 325 > > +++++++++++++++++++++++++++++++++++++ > > include/hw/s390x/s390_flic.h | 51 ++++-- > > Shouldnt we move this to include/hw/intc/ ? Current code is a bit undecided: Some interrupt controllers (like arm gic) have their headers in include/hw/intc/, some (like openpic and xics) in the architecture specific directories. Should we decide to collect all of those headers in include/hw/intc/, I vote for doing that in a general sweep. > > Otherwise: > Reviewed-by: Christian Borntraeger <[email protected]> > > > > 5 files changed, 399 insertions(+), 299 deletions(-) > > create mode 100644 hw/intc/s390_flic_kvm.c
