On 29.04.2014 17:41, Eric Blake wrote:
On 04/29/2014 09:07 AM, Max Reitz wrote:
After the top image has been committed, it should be emptied unless
specified otherwise.
Signed-off-by: Max Reitz <[email protected]>
---
qemu-img-cmds.hx | 4 ++--
qemu-img.c | 34 +++++++++++++++++++++++++++++++---
qemu-img.texi | 6 +++++-
3 files changed, 38 insertions(+), 6 deletions(-)
+ /* The block job will swap base_bs and bs (which is not what we really want
+ * here, but okay) and unref bs (and subsequently all intermediate block
+ * devices). In order to be able to empty these images afterwards,
increment
+ * the reference counter here preemptively. */
Comment is stale, since we aren't going to "empty these images", only
the top image.
Ah, right. I worked so long on this version that I simply forgot to
adjust this in the end.
+The image @var{filename} is emptied after the operation has been successful. If
s/has been successful/has succeeded/
+you do not need @var{filename} afterwards anymore and intend to drop it, you
may
s/ anymore//
+skip this operation by specifying the @code{-d} flag.
s/this operation/emptying @var{filename}/
The code looks okay, but as my tweaks include user-visible
documentation, you may want to post another revision just to make sure
it reads well. But we're close enough that if you only need to make the
changes I suggested, I'm fine with:
Reviewed-by: Eric Blake <[email protected]>
Thank you, I will most certainly adjust this as I do expect some
comments about patch 3. ;-)
Max
