On 04/23/2014 09:12 AM, Kevin Wolf wrote: > All the functionality to use the host_device, host_cdrom and host_floppy > drivers is already there, they just need to be added to the schema. > > Signed-off-by: Kevin Wolf <[email protected]> > --- > qapi-schema.json | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 391356f..0fc0f12 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -4288,7 +4288,8 @@ > # Since: 2.0
We haven't been good at tracking enum growth, but it can't hurt to try.
It might be worth changing this line to read:
# Since: 2.0, 'host_device', 'host_cdrom', 'host_floppy' since 2.1
> ##
> { 'enum': 'BlockdevDriver',
> - 'data': [ 'file', 'http', 'https', 'ftp', 'ftps', 'tftp', 'vvfat',
> 'blkdebug',
> + 'data': [ 'file', 'host_device', 'host_cdrom', 'host_floppy',
Any reason you used _ instead of - in these names? Newer QMP tends to
prefer - unless there is a good reason why _ has already been baked in
due to back-compat.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
