On 04/17/2014 05:53 AM, Kevin Wolf wrote: > This patch adds an errp parameter to bdrv_new() and updates all its > callers. The next patch will make use of this in order to check for > duplicate IDs. Most of the callers know that their ID is fine, so they > can simply assert that there is no error. > > Behaviour doesn't change with this patch yet as bdrv_new() doesn't > actually assign errors to errp. > > Signed-off-by: Kevin Wolf <[email protected]> > ---
> @@ -1220,7 +1220,8 @@ void bdrv_append_temp_snapshot(BlockDriverState *bs,
> Error **errp)
> qdict_put(snapshot_options, "file.filename",
> qstring_from_str(tmp_filename));
>
> - bs_snapshot = bdrv_new("");
> + bs_snapshot = bdrv_new("", &local_err);
> + assert(!local_err);
Please write this as bdrv_new("", &error_abort) rather than as two
lines; throughout the patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
