Re: [Qemu-devel] [PATCH 9/9] s390x/kvm: sync gbea and pp register

[Cornelia Huck]

On Wed, 16 Apr 2014 13:32:43 +0200
Alexander Graf <ag...@suse.de> wrote:

> 
> On 14.04.14 18:48, Cornelia Huck wrote:
> > From: Christian Borntraeger <borntrae...@de.ibm.com>
> >
> > We also need to sync guest breaking event address and program parameter
> > register for migration support.
> >
> > Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com>
> > Reviewed-by: Jason J. Herne <jjhe...@us.ibm.com>
> > Reviewed-by: Thomas Huth <th...@linux.vnet.ibm.com>
> > Signed-off-by: Cornelia Huck <cornelia.h...@de.ibm.com>
> > ---
> >   target-s390x/cpu.h |    3 +++
> >   target-s390x/kvm.c |   24 ++++++++++++++++++++++++
> >   2 files changed, 27 insertions(+)
> >
> > diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h
> > index 53391fd..55ef6d3 100644
> > --- a/target-s390x/cpu.h
> > +++ b/target-s390x/cpu.h
> > @@ -126,6 +126,9 @@ typedef struct CPUS390XState {
> >       uint64_t pfault_compare;
> >       uint64_t pfault_select;
> >   
> > +    uint64_t gbea;
> > +    uint64_t pp;
> > +
> >       CPU_COMMON
> >   
> >       /* reset does memset(0) up to here */
> > diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
> > index ec1ce2f..03d61d3 100644
> > --- a/target-s390x/kvm.c
> > +++ b/target-s390x/kvm.c
> > @@ -204,6 +204,18 @@ int kvm_arch_put_registers(CPUState *cs, int level)
> >           }
> >       }
> >   
> > +    reg.id = KVM_REG_S390_GBEA;
> > +    reg.addr = (__u64) &env->gbea;
> > +    if (kvm_vcpu_ioctl(cs, KVM_SET_ONE_REG, &reg)) {
> 
> Maybe we should have helpers for SET_ONE_REG and GET_ONE_REG as well ;). 
> Those could even contain the traces ;).
> 
> 
> Alex

Makes sense - next version of patch 8 will introduce helpers.