May any member help to check them?
And next, I shall try to find bug issues (not code style or document
issues), and fix them. Hope I can succeed.
Thanks.
On 04/08/2014 08:00 PM, Chen Gang wrote:
> In "vl.c", at least, we can simplify the code below, so can let readers
> read professional C code (especially for new readers, which often start
> reading code at main function).
>
> - remove useless 'continue' in main().
>
> - remove redundant local variable 'res' in get_boot_device().
>
> - remove local variable 'args' in the middle of code block in main().
>
> The following 3 patches are for the 3 'remove' above.
>
> And "vl.c" has a very long function main() which is about 17K lines.
> Next, it can be split into sub-functions (so can bypass another code
> style issue: multiple "{...}" styles within "swith(...)").
>
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> vl.c | 23 ++++++++++-------------
> 1 file changed, 10 insertions(+), 13 deletions(-)
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
