On 14 April 2014 07:04, Peter Crosthwaite <[email protected]> wrote: > On Fri, Apr 11, 2014 at 2:15 AM, Peter Maydell <[email protected]> > wrote: >> From: Rob Herring <[email protected]> >> + switch (cs->exception_index) { >> + case EXCP_PREFETCH_ABORT: >> + case EXCP_DATA_ABORT: >> + qemu_log_mask(CPU_LOG_INT, "...with FAR 0x%" PRIx64 "\n", >> + env->cp15.far_el1); > > need a /* fallthrough */
I think a simple 'break;' would be better, actually. > otherwise: > > Reviewed-by: Peter Crosthwaite <[email protected]> thanks -- PMM
