On Wed, 04/09 22:41, Jeff Cody wrote:
> The _rm_test_img() function in common.rc did not quote the image
> file, which left droppings in the scratch directory (and performed
> a potentially unsafe rm -f).
>
> This adds the necessary quotes.
>
> Signed-off-by: Jeff Cody <[email protected]>
> ---
> tests/qemu-iotests/common.rc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> index 7f00883..195c564 100644
> --- a/tests/qemu-iotests/common.rc
> +++ b/tests/qemu-iotests/common.rc
> @@ -178,10 +178,10 @@ _rm_test_img()
> local img=$1
Since we are quoting $img, should we quote $1 as well?
Fam
> if [ "$IMGFMT" = "vmdk" ]; then
> # Remove all the extents for vmdk
> - $QEMU_IMG info $img 2>/dev/null | grep 'filename:' | cut -f 2 -d: \
> + "$QEMU_IMG" info "$img" 2>/dev/null | grep 'filename:' | cut -f 2
> -d: \
> | xargs -I {} rm -f "{}"
> fi
> - rm -f $img
> + rm -f "$img"
> }
>
> _cleanup_test_img()
> --
> 1.8.3.1
>
>
