Am 13.03.2014 12:22, schrieb Peter Maydell: > On 13 March 2014 00:27, Andreas Färber <[email protected]> wrote: >> Hello Peter, >> >> This is my QOM (devices) patch queue. Please pull. >> >> v2 changes qom-test. > > No, this is still broken: > /home/petmay01/linaro/qemu-for-merges/tests/qom-test.c: In function ‘qmp’: > /home/petmay01/linaro/qemu-for-merges/tests/libqtest.h:359:60: sorry, > unimplemented: function ‘qmp’ can never be inlined because it uses > variable argument lists > make: *** [tests/qom-test.o] Error 1 > make: Leaving directory `/home/petmay01/linaro/qemu-for-merges/build/all' > > Moving qmp() into libqtest.c and just having a > prototype in libqtest.h (ie having it not be an > inline varargs function) seems to fix this. > > I don't know why (a) it didn't complain about > earlier uses of qmp() or (b) why it's not complaining > about qmp_discard_response() now [perhaps the compiler > manages to special case "varargs but the varargs list > is empty]. Probably safest to move qmp_discard_response > too, though.
My v1 did have empty varargs, so that's not it... Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
