Am 12.03.2014 15:15, schrieb Peter Maydell: > On 12 March 2014 13:24, Peter Maydell <[email protected]> wrote: >> Remove the custom qemu_assert() function defined by target-m68k/translate.c >> in favour of either using glib g_assert_not_reached() (for the genuinely >> can't-happen cases) or cpu_abort() (for the "this isn't implemented", >> in line with other unimplemented cases in the target). >> >> This has the benefit of silencing some clang warnings about >> variables used while uninitialized (which are emitted because >> clang can't figure out that qemu_assert(0, something) never >> returns. >> >> Signed-off-by: Peter Maydell <[email protected]> > > Andreas pointed out that we've had one attempt to fix this > late last year: > http://lists.gnu.org/archive/html/qemu-devel/2013-12/msg02177.html > which didn't work because hw_assert() is not present in user-mode > compiles. This version of the patch doesn't suffer from that issue.
Reviewed-by: Andreas Färber <[email protected]> Looks fine then, except that cpu_abort() will conflict with my series. Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
