Am 20.02.2014 23:22, schrieb Peter Maydell: > On 20 February 2014 21:26, Stefan Weil <[email protected]> wrote: >> There was a suggestion to remove some dependencies on windows.h (which >> causes the trouble here). I recently started doing this, and that >> approach fixes the warning, too. Maybe I can send a patch next weekend. > > That would probably be the nicest approach, yes. I won't apply > this to the target-arm queue just yet. > > I'm wondering if we might be able to get to the point of enabling > -Werror for Windows and MacOSX builds. Do you think that would > be a useful thing to do? (Obviously for git builds only, same as Linux.)
Yes, I think so. With MinGW-w64 this is quite realistic, even when I add -Wextra (which I also use for my Linux builds). Some less important warnings must be suppressed then, of course. > (For MacOSX there are some deprecation warnings in the audio > code I need to fix first but we otherwise compile pretty much > warning free on 10.8. I'd be reliant on reports from other people > for warnings on 10.9 and on earlier-than-10.8, though.) 10.9 also shows the audio deprecation warnings, but that's all as far as I remember. Stefan
