On Fri, Feb 14, 2014 at 03:12:41PM +0100, Stefan Hajnoczi wrote:
> On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote:
> > diff --git a/block/gluster.c b/block/gluster.c
> > index a009b15..79af3fd 100644
> > --- a/block/gluster.c
> > +++ b/block/gluster.c
> > @@ -30,6 +30,8 @@ typedef struct GlusterAIOCB {
> > typedef struct BDRVGlusterState {
> > struct glfs *glfs;
> > struct glfs_fd *fd;
> > + int open_flags;
>
> Is this field used? I only see stores to this field but no loads.
>
> Seems unnecessary since the block layer already provides us with QEMU
> BDRV_* flags and qemu_gluster_parse_flags() can be used to produce POSIX
> open(2) flags from them.
It is not currently used, I cached it for later use, but never used
it. I will purge it in a v2 (same thing with the sister variable in
the reopen state struct in patch 2).
