Am 16.12.2013 09:05, schrieb edgar.igles...@gmail.com: > From: "Edgar E. Iglesias" <edgar.igles...@xilinx.com> > > Signed-off-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> > --- > exec.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/exec.c b/exec.c > index edb6a43..203c8e4 100644 > --- a/exec.c > +++ b/exec.c > @@ -1810,6 +1810,11 @@ static void tcg_commit(MemoryListener *listener) > reset the modified entries */ > /* XXX: slow ! */ > CPU_FOREACH(cpu) { > + /* FIXME: Disentangle the cpu.h circular files deps so we can > + directly get the right CPU from listener. */
Was this circular dependency explained somewhere? > + if (cpu->tcg_as_listener != listener) { > + continue; > + } If this is to be committed (rather than fixed in a v2), please move to below variables as usual. Regards, Andreas > CPUArchState *env = cpu->env_ptr; > > tlb_flush(env, 1); -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg