Am 30.10.2013 14:54, schrieb Stefan Hajnoczi: > Existing qmp() callers do not expect a response object. In order to > implement real QMP test cases it will be necessary to inspect the > response object. > > Rename qmp() to qmp_discard_response(). Later patches will introduce a > qmp() function that returns the response object and tests that use it. > > Signed-off-by: Stefan Hajnoczi <[email protected]> > --- > tests/boot-order-test.c | 4 ++-- > tests/fdc-test.c | 15 +++++++++------ > tests/ide-test.c | 10 ++++++---- > tests/libqtest.c | 8 ++++---- > tests/libqtest.h | 20 ++++++++++---------- > 5 files changed, 31 insertions(+), 26 deletions(-)
Reviewed-by: Andreas Färber <[email protected]> I notice that at least in two places [qtest_]qmp() was being called with literal "" argument. If we could get a separate qmp_wait_for_ready() or so function, then we could actually enabling format string checking for those functions. That'd a follow-up though. Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
