On 10/31/2013 09:57 AM, Jeff Cody wrote: > _make_test_img() currently works with spaced pathnames only when not > specifying a backing file. This fixes it so that the backing file > argument is properly quoted. > > Signed-off-by: Jeff Cody <[email protected]> > --- > tests/qemu-iotests/common.rc | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <[email protected]> As a slight optimization, you could avoid a subshell: > # XXX(hch): have global image options? > - $QEMU_IMG create -f $IMGFMT $extra_img_options $img_name $image_size > 2>&1 | \ > + ( > + if [ $use_backing = 1 ]; then > + $QEMU_IMG create -f $IMGFMT $extra_img_options -b "$backing_file" > "$img_name" $image_size 2>&1 > + else > + $QEMU_IMG create -f $IMGFMT $extra_img_options "$img_name" > $image_size 2>&1 > + fi > + ) | \ $QEMU_IMG create -f $IMGFMT $extra_img_options \ ${backing_file:+-b "$backing_file"} "$img_name" $image_size 2>&1 | But as not everyone is a shell guru to recognize the ${var+:expansion} trick, I'm fine with the version you proposed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
