On 10/02/2013 04:23 AM, Sebastian Ottlik wrote: > This patchset disables most uses of SO_REUSEADDR on Windows and replaces it > with > calls to the new function socket_set_fast_reuse. On Windows systems the > default > behaviour is equivalent to SO_REUSEADDR on other operating systems. > SO_REUSEADDR > can still be set but results in undesired behaviour in most cases. It may even > lead to situations were system behaviour is unspecified. More information on > this can be found at: > http://msdn.microsoft.com/en-us/library/windows/desktop/ms740621.aspx > > I originally encountered this issue when accidentally launching two QEMU > instances with identical GDB ports at the same time. In which case QEMU won't > fail as one might expect. > > Note that patch #4 fails checkpatch.pl. This is intentional (see v3 changes). > > v6 Changes: > - dropped error output and the silent parameter in favor of an assertion > > Actually I wanted to remove the return value from the function too, as the > assertion pretty much states that the function will not fail and thus always > return 0. However this would make the code a little ugly to prevent unused > variable warnings if NDEBUG is set (see patch 1) and also would require some > ugly changes to slirp/socket.c (see patch 4). Thus I decided to keep it. > > - Rebased to current master (a684f3cf9b9b9c3cb82be87aafc463de8974610c) >
Series: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
