On 10/01/2013 07:20 AM, Kevin Wolf wrote: > Working on a QDict instead of a QemuOpts that accepts anything is more > in line with bdrv_open(). A QDict is what qmp_blockdev_add() already has > anyway, so this saves additional conversions. And last, but not least, > it allows later patches to easily extract legacy options into a > separate, typed QemuOpts for drive_init() (the untyped QemuOpts that > drive_init already has doesn't allow access to numbers, only strings, > and is therefore useless without conversion). > > Signed-off-by: Kevin Wolf <[email protected]> > Reviewed-by: Benoit Canet <[email protected]> > --- > blockdev.c | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-)
Reviewed-by: Eric Blake <[email protected]> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
