Stefan Weil <[email protected]> writes:

> Am 29.09.2013 22:13, schrieb Michael Tokarev:
>> 29.09.2013 19:41, Stefan Weil wrote:
>>> The QEMU buildbot default_i386_debian_6_0 shows this warning:
>>>
>>>    CC    migration.o
>>> migration.c: In function 'qmp_query_migrate_capabilities':
>>> migration.c:149: warning:
>>>   'caps' may be used uninitialized in this function
>>
>> Gah, how disgusting.  The code is correct, yet gcc complains
>> needlessly...
>
> That's not the first time where we help the compiler by modifying the code.

It's also not the first time where attempting to "help" the compiler
made code less readable, or even less correct.  So let's be just as
careful as with "real" changes.

Reply via email to