Le 07/09/2013 10:43, Peter Maydell a écrit :
On 6 September 2013 21:47, Laurent Vivier <laur...@vivier.eu> wrote:
This series of patch allows to set the default CPU used by linux-user qemu.

When qemu is used in a container as a binfmt interpreter we can't use the
environment variable QEMU_CPU to set the CPU id.
I definitely don't like this. We shouldn't be hardcoding this at
configure time. There doesn't seem to be any particular reason
why QEMU_CPU is the only option you might want to set for
your binfmt-interpreter either.
In fact, I don't understand why a given CPU id has been chosen to be the default value. I think there is a default value not because this is the best/most used value but because we need a default. It's hardcoded at development time. So I think this is better to be able to choose this default value without editing any file. A configuration option is the best solution for me. Moreover, this doesn't change the default behavior.
Is there a reason why using a wrapper script which sets
options to the real qemu binary won't work?
Personal reason : I don't like wrapper. Kernel must load two executables, wrapper must analyze environment, auxv, parameters and pass what it needs to pass.

But I don't want to push these patches at any reason : I just want to share.

Thank you for your comments.

Regards,
Laurent

Reply via email to