Re: [Qemu-devel] [PATCH 2/9] char: introduce tcp_chr_detach()

[Gerd Hoffmann]

  Hi,

> +static void tcp_chr_detach(CharDriverState *chr)
> +{
> +    TCPCharDriver *s = chr->opaque;
> +
> +    if (s->tag) {
> +        io_remove_watch_poll(s->tag);
> +        s->tag = 0;
> +    }
> +}

Lots of simliar functions in the other patches.

Doesn't it make sense to move the tag field from TCPCharDriver to
CharDriverState instead, so we don't need a new callback in the first
place?

cheers,
  Gerd