Am 26.08.2013 um 08:22 schrieb Benjamin Herrenschmidt <[email protected]>:
> On Mon, 2013-08-26 at 06:44 +0100, Alexander Graf wrote: >>> + cap.flags = 0; >>> + cap.migration.ecl = 0; >>> + cap.reserve.type = 0; >>> + cap.migration.common.server_support = 0; >>> + cap.reserve.common.server_support = 0; >> >> My question stands unanswered. Is this just memset(0)? > > If it is, then why bother reading it in the first place ? :-) Because this is a revision that incorporates other feedback from that same review, so I'm quite sure he just missed it :) > > Note that even if it is, I'd rather keep it that way as we are > eventually going to populate some stuff and so we have just the > placeholders to do it. Do we ever need to preserve random fields in that struct? Or would it be clearer to just set the whole thing to 0 and then go from there? It's definitely a case-by-case decision which way is better, but setting all fields by hand gives you potential for missing to set one. Alex > > Cheers, > Ben. > >
