On 4 July 2013 14:09, Markus Armbruster <[email protected]> wrote: > > +/** > + * Get machine options > + * > + * Returns: machine options (never null). > + */ > +QemuOpts *qemu_get_machine_opts(void) > +{ > + QemuOptsList *list; > + QemuOpts *opts; > + > + list = qemu_find_opts("machine"); > + assert(list); > + opts = qemu_opts_find(list, NULL); > + if (!opts) { > + opts = qemu_opts_create_nofail(list); > + } > + return opts; > +}
This looks a bit odd -- why are we creating new options in a function that claims to only be querying them? thanks -- PMM
