Hi Frederic, On Tue, Jun 11, 2013 at 5:09 PM, Frederic Konrad <[email protected]> wrote: > Hi, > > > On 11/06/2013 08:49, [email protected] wrote: >> >> From: Peter Crosthwaite <[email protected]> >> >> Use standard QOM cast macro. Remove usages of container_of() and >> direct -> style upcasting. >> >> Signed-off-by: Peter Crosthwaite <[email protected]> > > [...] > >> static inline VirtIOPCIProxy *to_virtio_pci_proxy(DeviceState *d) >> { >> - return container_of(d, VirtIOPCIProxy, pci_dev.qdev); >> + return VIRTIO_PCI(d); >> } > > > Maybe you can replace each to_virtio_pci_proxy directly with VIRTIO_PCI? >
I'm going to drop this one V2 for the moment and revisit is later. Its more complicated, given the replications between the fast and slow versions and needs a little more research (and a mini series of its own). Regards, Peter
