Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

[Stefan Hajnoczi]

On Mon, Jun 17, 2013 at 11:43:24AM +0800, Fam Zheng wrote:
> > +    bdrv_iostatus_disable(target);
> > +    bdrv_delete(job->target);
> 
> drive-mirror has bdrv_close before deleting target, why don't we need
> one here?

Use the source, Luke! :)

void bdrv_delete(BlockDriverState *bs)
{
    assert(!bs->dev);
    assert(!bs->job);
    assert(!bs->in_use);

    bdrv_close(bs);

    /* remove from list, if necessary */
    bdrv_make_anon(bs);

    g_free(bs);
}

Stefan