Markus Armbruster <arm...@redhat.com> writes:
> libqtest's qtest_init() connecting to the qtest socket triggers reset.
> This was coded in the hope we could use the same QEMU process for
> multiple tests that way. Never used. Injects an extra reset even
> when it's not used, and that can mess up tests such as the one of
> -boot once I'm about to add. Drop it.
>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
We could always add a reset qtest command. Probably makes more sense really.
Reviewed-by: Anthony Liguori <aligu...@us.ibm.com>
Regards,
Anthony Liguori
> ---
> qtest.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/qtest.c b/qtest.c
> index 07a9612..74f1842 100644
> --- a/qtest.c
> +++ b/qtest.c
> @@ -472,7 +472,12 @@ static void qtest_event(void *opaque, int event)
>
> switch (event) {
> case CHR_EVENT_OPENED:
> - qemu_system_reset(false);
> + /*
> + * We used to call qemu_system_reset() here, hoping we could
> + * use the same process for multiple tests that way. Never
> + * used. Injects an extra reset even when it's not used, and
> + * that can mess up tests, e.g. -boot once.
> + */
> for (i = 0; i < ARRAY_SIZE(irq_levels); i++) {
> irq_levels[i] = 0;
> }
> --
> 1.7.11.7
