Am 11.06.2013 17:52, schrieb Luiz Capitulino: > On Sun, 9 Jun 2013 18:10:42 +0200 > Andreas Färber <[email protected]> wrote: > >> We relied on the CPUClass::get_memory_mapping() implementation being a >> no-op when paging is disabled for that CPU. Therefore we can just as well >> iterate over all CPUs to retrieve mappings. >> >> This allows to use qemu_for_each_cpu() instead of open-coding CPU loops. >> >> Pass any Error out into dump_init() and have it actually stop on errors. >> Whether it is unsupported on a certain CPU can be checked by looking for >> a NULL CPUClass::get_memory_mapping field. >> >> Signed-off-by: Andreas Färber <[email protected]> > > Reviewed-by: Luiz Capitulino <[email protected]>
Thanks, reverted CPU loop changes and applied to qom-cpu as pure error handling improvement: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
