On 15/04/2013 15:34, Andreas Färber wrote:
Am 14.04.2013 15:01, schrieb [email protected]:
From: KONRAD Frederic <[email protected]>
As the virtio-rng-pci and virtio-rng-s390 are switched to the new API,
and virtio-rng-ccw ;)
we can use QOM casts.
Signed-off-by: KONRAD Frederic <[email protected]>
---
hw/virtio/virtio-rng.c | 31 +++++++++++++++++--------------
include/hw/virtio/virtio-rng.h | 2 +-
2 files changed, 18 insertions(+), 15 deletions(-)
Thanks,
Reviewed-by: Andreas Färber <[email protected]>
I was surprised to see FOO(opaque) since we usually try to avoid it for
performance reasons, but it's not forbidden either.
True, I had taken that in account but forget this series :/.
Is it better to change that?
Thanks,
Fred
Also, leaving the variable name as "s" would've spared a few lines but
so what. :)
Regards,
Andreas
