On Fri, 12 Apr 2013 16:25:11 -0300
Eduardo Habkost <[email protected]> wrote:
> On Fri, Apr 12, 2013 at 01:17:32PM +0200, Igor Mammedov wrote:
> [...]
> > >
[...]
> >
> > diff --git a/include/hw/pci/msi.h b/include/hw/pci/msi.h
> > index d4d0450..c159a15 100644
> > --- a/include/hw/pci/msi.h
> > +++ b/include/hw/pci/msi.h
> > @@ -21,15 +21,15 @@
> > #ifndef QEMU_MSI_H
> > #define QEMU_MSI_H
> >
> > -#ifndef CONFIG_USER_ONLY
> > #include "qemu-common.h"
>
> By the way, have you tried to eliminate the qemu-common.h include above?
> (not important now, but asking just in case you have tried and found issues)
No, that would be just another bunch of not related cleanup patches.
>
> > -#include "hw/pci/pci.h"
> >
> > struct MSIMessage {
> > uint64_t address;
> > uint32_t data;
> > };
> >
> > +#ifndef CONFIG_USER_ONLY
> > +#include "hw/pci/pci.h"
> > extern bool msi_supported;
> >
> > void msi_set_message(PCIDevice *dev, MSIMessage msg);
> > diff --git a/kvm-stub.c b/kvm-stub.c
> > index 8cb81c4..b5d4446 100644
> > --- a/kvm-stub.c
> > +++ b/kvm-stub.c
> > @@ -123,7 +123,6 @@ int kvm_on_sigbus(int code, void *addr)
> > return 1;
> > }
> >
> > -#ifndef CONFIG_USER_ONLY
> > int kvm_irqchip_add_msi_route(KVMState *s, MSIMessage msg)
> > {
> > return -ENOSYS;
> > @@ -147,4 +146,3 @@ int kvm_irqchip_remove_irqfd_notifier(KVMState *s,
> > EventNotifier *n, int virq) {
> > return -ENOSYS;
> > }
> > -#endif
> >
> > >
> > > --
> > > Eduardo
> >
> >
> > --
> > Regards,
> > Igor
>
