>>
>> -void bdrv_image_info_dump(ImageInfo *info)
>> +void bdrv_image_info_dump(GString *buf, ImageInfo *info)
>> {
>> char size_buf[128], dsize_buf[128];
>> if (!info->has_actual_size) {
>> @@ -370,43 +369,48 @@ void bdrv_image_info_dump(ImageInfo *info)
>
> I don't like this change, because it introduces buffering for no
> discernible reason. Unless you can show me one, I'd like you to keep
> printing directly.
>
HMP code later need to call this function, and then print buf to
monitor console, which is the goal of this patch.
>> info->actual_size);
>> }
>>
>> static gboolean str_equal_func(gconstpointer a, gconstpointer b)
>> diff --git a/savevm.c b/savevm.c
>> index e4e0008..ce0bbe1 100644
>> --- a/savevm.c
>> +++ b/savevm.c
>> @@ -2466,7 +2466,7 @@ void do_info_snapshots(Monitor *mon, const QDict
>> *qdict)
>> int nb_sns, i, ret, available;
>> int total;
>> int *available_snapshots;
>> - char buf[256];
>> + GString *buf = NULL;
>
> Useless initialization. But if you keep bdrv_snapshot_dump() printing,
> it all goes away.
>
will remove.
--
Best Regards
Wenchao Xia
